automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] {master} release-stats: account for generated `instspc-*.tes


From: Ralf Wildenhues
Subject: Re: [PATCH] {master} release-stats: account for generated `instspc-*.test' tests.
Date: Sat, 20 Nov 2010 06:58:14 +0100
User-agent: Mutt/1.5.20 (2010-08-04)

* Stefano Lattarini wrote on Fri, Nov 19, 2010 at 09:18:33PM CET:
> I've realized that my patch on instspc.test split & refactoring has
> broken the "release-stats" target, since now there are other generated
> tests besides the `*-p.test' tests.
> 
> The attached patch fix this glitch in a "quick & dirty" way; a better
> fix would probably involve a refactoring of the whole "release-stats"
> target, but that can be done later IMHO.
> 
> So, OK to apply the attached patch to a temporary branch based off
> of commit `v1.11-395-ge118126' "Overhauled and modularized tests in
> `instspc.test'.", and merge to master?

This will break again when we add the next set of generated tests.
How about determining them by grepping the test source for 'GENERATED
AUTOMATICALLY' in the test source?  OK with that change, and after
testing suitably.

Thanks,
Ralf

> From 00dbb4fe7d27510718a60d721c932d4f8fb6b2dc Mon Sep 17 00:00:00 2001
> From: Stefano Lattarini <address@hidden>
> Date: Fri, 19 Nov 2010 21:16:03 +0100
> Subject: [PATCH] release-stats: account for generated `instspc-*.test' tests.
> 
> * Makefile.am (release-stats): Also account for generated tests
> `instspc-*.test'.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]