automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCHES] Fix spurious failures of some tests `silent*.test' with Su


From: Stefano Lattarini
Subject: Re: [PATCHES] Fix spurious failures of some tests `silent*.test' with SunStudio Fortran
Date: Wed, 17 Nov 2010 20:33:28 +0100
User-agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; )

On Wednesday 17 November 2010, Ralf Wildenhues wrote:
>
> I haven't made up my mind yet.  At the moment I'm trying to find out
> whether it is suitable or desirable for the silent-rules option to
> trigger configure checks that set additional flags like -silent if
> verbose mode is not enabled.
>
I'm not sure that would be a good idea.
 
> If we go this way, we shouldn't just do it for this one compiler.
> I know at least two more: another Fortran compiler, and MSVC, where
> this issue came up before already.  A survey about other compilers
> would be good, before implementing something along these lines.
 
> > > The user might just not want to read that NOTICE.
> > > 
> > > If not, then I'd squash the two patches together (is there a point in
> > > keeping them separate?),
> > >
> > Well, they fix bugs introduced in two different commits, so they should
> > be applied to different bug-fixing branches IMHO.
> 
> However you like.  I wouldn't call this a bug in the commit though,
> rather a bug in the compiler which we work around.
> 
> > > and relax the sed pattern to kill all lines matching '^NOTICE:'.
> > >
> > I can amend both the patches to do so.
> 
> Yes, I think for the moment that is the best route.
>
OK, I've amended the patches, merged them in maint, merged maint in
master, and pushed.

Regards,
  Stefano



reply via email to

[Prev in Thread] Current Thread [Next in Thread]