[PATCH] tests/yaccdry.test ($required): Require bison. (was: Re: More problems with `make -n' in automake-generated rules.)

[Stefano Lattarini]

I'm seeing this failure in test yaccdry.test at the Hydra continuous
build system for automake:

 <http://hydra.nixos.org/build/745050/log>

 > FAIL: yaccdry.test (exit: 2) 
 > ============================ 
 > /tmp/nix-build-9l5zbyj69kwsr3iyps70a2a5nsnpj7hn-automake-1.11a.drv-0/automake-1.11a/tests:/...
 > ++ pwd 
 > /tmp/nix-build-9l5zbyj69kwsr3iyps70a2a5nsnpj7hn-automake-1.11a.drv-0/automake-1.11a/tests/yaccdry.dir
 >  
 > + set -e 
 > + cat 
 > + cat 
 > + cat 
 > + cat 
 > + aclocal-1.11a -Werror 
 > + automake-1.11a --foreign -Werror -Wall --add-missing 
 > configure.in: installing `./ylwrap' 
 > + autoconf 
 > + ./configure 
 > checking for a BSD-compatible install... /...-coreutils-8.4/bin/install -c 
 > checking whether build environment is sane... yes 
 > checking for a thread-safe mkdir -p... /...-coreutils-8.4/bin/mkdir -p 
 > checking for gawk... gawk 
 > checking whether make sets $(MAKE)... yes 
 > checking for gcc... gcc 
 > checking whether the C compiler works... yes 
 > checking for C compiler default output file name... a.out 
 > checking for suffix of executables...  
 > checking whether we are cross compiling... no 
 > checking for suffix of object files... o 
 > checking whether we are using the GNU C compiler... yes 
 > checking whether gcc accepts -g... yes 
 > checking for gcc option to accept ISO C89... none needed 
 > checking for style of include used by make... GNU 
 > checking dependency style of gcc... gcc3 
 > checking for bison... no 
 > checking for byacc... no 
 > configure: creating ./config.status 
 > config.status: creating Makefile 
 > config.status: executing depfiles commands 
 > + make 
 > gcc -DPACKAGE_NAME=\"yaccdry\" -DPACKAGE_TARNAME=\"yaccdry\" \
 >     -DPACKAGE_VERSION=\"1.0\" -DPACKAGE_STRING=\"yaccdry\ 1.0\" \
 >     -DPACKAGE_BUGREPORT=\"\" -> DPACKAGE_URL=\"\" \
 >     -DPACKAGE=\"yaccdry\" -DVERSION=\"1.0\" \
 >     -I. -g -O2 \
 >     -MT foo.o -MD -MP -MF .deps/foo.Tpo -c -o foo.o foo.c 
 > mv -f .deps/foo.Tpo .deps/foo.Po 
 > /bin/sh ./ylwrap parse.y y.tab.c parse.c y.tab.h parse.h y.output 
 > parse.output -- yacc -d
 > ./ylwrap: line 113: yacc: command not found
 > make: *** [parse.c] Error 1 
 > + exit_status=2 
 > + set +e 
 > + cd 
 > /tmp/nix-build-9l5zbyj69kwsr3iyps70a2a5nsnpj7hn-automake-1.11a.drv-0/automake-1.11a/tests
 >  
 > + case $exit_status,$keep_testdirs in 
 > + test 0 '!=' 0 
 > + echo 'yaccdry: exit 2' 
 > yaccdry: exit 2 
 > + exit 2

OK to apply the attached patch to a temporary bugfix branch to be
then merged into maint?

Regards,
  Stefano

From 279d77d1043a0d5235b88ddba99d05fdc2be96ee Mon Sep 17 00:00:00 2001
From: Stefano Lattarini <address@hidden>
Date: Mon, 15 Nov 2010 02:12:10 +0100
Subject: [PATCH] tests/yaccdry.test ($required): Require bison.

---
 ChangeLog          |    4 ++++
 tests/yaccdry.test |    1 +
 2 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 6c17cd3..af7e7cd 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2010-11-15  Stefano Lattarini  <address@hidden>
+
+       * tests/yaccdry.test ($required): Require bison.
+
 2010-11-01  Ralf Wildenhues  <address@hidden>
 
        Fix and document rules to not touch the tree with `make -n'.
diff --git a/tests/yaccdry.test b/tests/yaccdry.test
index d11d3fe..d2e7632 100755
--- a/tests/yaccdry.test
+++ b/tests/yaccdry.test
@@ -16,6 +16,7 @@
 
 # Removal recovery rules for headers should not remove files with `make -n'.
 
+required=bison
 . ./defs || Exit 1
 
 set -e
-- 
1.7.1