Re: [PATCH] {master} Deprecate obsoleted macro AM_WITH_REGEX.

[Ralf Wildenhues]

* Stefano Lattarini wrote on Sat, Nov 13, 2010 at 12:32:49PM CET:
> * m4/regex.m4: Document the `AM_WITH_REGEX' macro as obsoleted,

I think technically "obsolete" is right here, without trailing "d".

> and tell that it should be removed two years from now.

s/tell/state/

> (AM_WITH_REGEX): Raise an m4-time warning of the "obsolete"
> category when this macro is used.
> * doc/automake.texi (Public Macros): Move description of
> `AM_WITH_REGEX' from here ...
> (Private Macros): ... to here, and declare it as obsoleted and

Did you mean (Obsolete Macros) here?

> "to be removed in a future version".
> * tests/regex-obsolete.test: New test.

That file is missing from the patch.  Please resend and I'll finish the
review.

> * tests/Makefile.am (TESTS): Update.

> address@hidden AM_WITH_REGEX
> address@hidden AM_WITH_REGEX
> address@hidden WITH_REGEX
> address@hidden --with-regex
> address@hidden regex package
> address@hidden rx package
> +Adds @option{--with-regex} to the @command{configure} command line.  If
> +specified (the default), then the @samp{regex} regular expression
> +library is used, @file{regex.o} is put into @code{LIBOBJS}, and
> address@hidden is defined.  If @option{--without-regex} is given, then
> +the @code{rx} regular expression library is used, and @file{rx.o} is put
> +into @code{LIBOBJS}.  This macro is obsolete now (since rx doesn't seem
> +to be maintained), and will be removed in a future version of Automake.

Is rx a package?  Where did you find traces to it?

How about adding "Consider using gnulib if you need regex
functionality."?

>  @end table

Thanks,
Ralf