Re: [PATCH 7/7] Tests defs: move static definitions in a new file `minidefs'.

[Stefano Lattarini]

On Wednesday 10 November 2010, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Sun, Nov 07, 2010 at 04:29:27PM CET:
> > Tests defs: move static definitions in a new file `minidefs'.
> 
> minidefs is not a good name,
True, but I couldn't think of a better one right away.  Luckily,
you could ;-)
> as it is bound to not stay "mini".
> How about defs-static or defs-init?
defs-static is good IMO.  I've settled for it.
> (And yes, I'm shying away from renaming defs, that's just too big and churny
> a change for such a slight misnomer.)
Yes, it would require modifying *all* the test scripts :-/
And I dare not to think about other possible merge problems ...
 
> > The new file is designed to be idempotent w.r.t. mutiple inclusions,
> 
> s/designed/meant/, no?
OK.

> I don't see a design document.  ;->
> 
> > and this will help us to cope better with e.g. generated tests and
> > tests with complex setups, scaffoldings or indirections.
> 
> What is scaffoldings?  I think the first line of the summary text was
> completely sufficient.
OK. Removed those lines.
 
> > * tests/defs.in: Removed, it's contents split among ...
> 
> its
*blush*
Fixed.

> > * tests/defs: ... this new file ...
> > * tests/minidefs.in: ... and this new file.
> 
> You need to mention the remaining changes here; e.g., that defs sources
> the other file now.
Is this OK?

 * tests/defs.in: Removed, its contents split among ...
 * tests/defs-static.in: ... this new file ...
 * tests/defs: ... and this new file, including the former.

> > * configure.ac (AC_CONFIG_FILES): Remove `tests/defs', add
> > `tests/minidefs'.
> > * configure.ac (AC_CONFIG_LINKS): Add `tests/defs'.
> > * tests/Makefile.am ($(parallel_tests)): Update.
> > ($(instspc_tests)): Likewise.
> > * tests/.gitignore: Update.
> 
> OK with those changes.
> 
> Thanks,
> Ralf
> 

Thanks,
  Stefano