automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Modernize, improve and/or tweak various test scripts.


From: Ralf Wildenhues
Subject: Re: [PATCH] Modernize, improve and/or tweak various test scripts.
Date: Sun, 7 Nov 2010 11:26:19 +0100
User-agent: Mutt/1.5.18 (2008-05-17)

* Stefano Lattarini wrote on Sun, Nov 07, 2010 at 11:18:49AM CET:
> On Sunday 07 November 2010, Ralf Wildenhues wrote:
> > * Stefano Lattarini wrote on Mon, Sep 13, 2010 at 11:22:37AM CEST:

> > > * tests/ctarget1.test: Renamed ...
> > 
> > Please don't rename tests unless for a very good reason,
> The good reason is IMHO that the name `ctarget1.test' is misleading
> w.r.t. the testcase's content.

Hmm, well, maybe.

> > and please don't reuse names from tests that have been removed.
> I didn't (we had alredy agreed that this would be bad practice); to
> verify that I'm speaking truth, try:
>   $ git lgl master -- tests/cond1.test
> There should be no output (works for me).

The test might not ever have made it to revision control, or it might
have been in a non-merged branch only (so use --all to look).  In case
of doubt, at least use a name not likely to have been used before.
Anyway cond1 also hints me that this is a very old test.

> So, ok to proceed with the rename?

Please use a new name if you must.

Thanks,
Ralf



reply via email to

[Prev in Thread] Current Thread [Next in Thread]