Re: [PATCH] dist-xz: don't hard-code -9: honor setting of XZ_OPT

[Ralf Wildenhues]

Hello Lasse, Jim,

with Jim's patch in place, and XZ_OPT *not* set in the environment,
I get the following Automake test failure with

$ xz --version
xz (XZ Utils) 4.999.8beta
liblzma 4.999.8beta

(yes, that's not the newest version; no, we shouldn't support just the
newest version).

So, time to rethink this feature?  Maybe we need to check first whether
XZ_OPT is parsed correctly by xz at all?

Thanks,
Ralf

FAIL: xz.test (exit: 2)
=======================

/tmp/build/tests:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games
xz: running xz --version
xz (XZ Utils) 4.999.8beta
liblzma 4.999.8beta
=== Running test ../../automake/tests/xz.test
+ pwd
/tmp/automake/build/tests/xz.dir
+ set -e
+ cat
+ cat
+ aclocal-1.11a -Werror
+ autoconf
+ automake-1.11a --foreign -Werror -Wall
+ ./configure
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
+ make test
make  dist-xz am__post_remove_distdir='@:'
make[1]: Entering directory `/tmp/build/tests/xz.dir'
{ test ! -d "xz-1.0" || { find "xz-1.0" -type d ! -perm -200 -exec chmod u+w {} 
';' && rm -fr "xz-1.0"; }; }
test -d "xz-1.0" || mkdir "xz-1.0"
test -n "" \
|| find "xz-1.0" -type d ! -perm -755 \
        -exec chmod u+rwx,go+rx {} \; -o \
  ! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
  ! -type d ! -perm -400 -exec chmod a+r {} \; -o \
  ! -type d ! -perm -444 -exec /bin/bash /tmp/build/tests/xz.dir/install-sh -c 
-m a+r {} {} \; \
|| chmod -R a+r "xz-1.0"
tardir=xz-1.0 && /bin/bash /tmp/build/tests/xz.dir/missing --run tar chof - 
"$tardir" | XZ_OPT=${XZ_OPT--9} xz -c >xz-1.0.tar.xz
xz: invalid option -- 'y'
xz: Try `xz --help' for more information.
WARNING: I can't seem to be able to run `tar' with the given arguments.
         You may want to install GNU tar or Free paxutils, or check the
         command line arguments.
make[1]: *** [dist-xz] Error 1
make[1]: Leaving directory `/tmp/build/tests/xz.dir'
make: *** [dist] Error 2
+ exit_status=2
+ set +e
+ cd /tmp/automake/build/tests
+ test 0 != 0
+ echo xz: exit 2
xz: exit 2
+ exit 2