automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Separate failing part of test `all.test'.


From: Ralf Wildenhues
Subject: Re: [PATCH] Separate failing part of test `all.test'.
Date: Sun, 8 Aug 2010 14:35:50 +0200
User-agent: Mutt/1.5.20 (2010-04-22)

* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 02:31:55PM CEST:
> At Sunday 08 August 2010, Ralf Wildenhues wrote:
> > * Stefano Lattarini wrote on Wed, Jul 14, 2010 at 01:36:57PM CEST:
> > > * tests/all.test: Run aclocal only once.  Minor cosmetic changes.
> > > Move checks that several *-local's in a single rule work ...
> > 
> > This sentence does not make sense to me.  Maybe a missing word?
> More likely broken english on my part, as the sentence still makes 
> sense to me.  It was intended to mean:
*snip explanation*

Thanks, I was missing something like  s/that/& test/  I guess.

> > Patch is OK, but I'd be happier if you could rename all.test to
> > all2.test and manylocal.test to all.test (with adjustments to
> > Makefile.am of course) so that
> > - it is clearer that all and all2 are related,
> > - comparison with old testsuite log results are still meaningful.
> OK, done.  But you might want to check that I really did what you 
> asked (see attachement).

Yep, thanks!
Ralf

> From 5f367849190c384c1fc4d3884b2061b1bdc0d1bb Mon Sep 17 00:00:00 2001
> From: Stefano Lattarini <address@hidden>
> Date: Wed, 14 Jul 2010 13:33:49 +0200
> Subject: [PATCH 8/9] Separate failing part of test `all.test'.
> 
> * tests/all.test: Keep only (x)failing part of the test.  Working
> checks moved out to ...
> * tests/all2.test: ... this new test.
> * tests/Makefile.am (TESTS): Updated.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]