[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Enable `errexit' shell flag in some test scripts.
From: |
Stefano Lattarini |
Subject: |
Re: [PATCH] Enable `errexit' shell flag in some test scripts. |
Date: |
Tue, 8 Jun 2010 20:45:50 +0200 |
User-agent: |
KMail/1.12.1 (Linux/2.6.30-2-686; KDE/4.3.4; i686; ; ) |
At Tuesday 08 June 2010, Ralf Wildenhues <address@hidden>
wrote:
> > -$ACLOCAL > output 2>&1 || { cat output; Exit 1; }
> > -test -z "`cat output`"
> > +$ACLOCAL >output 2>&1 || { cat output; Exit 1; }
>
> Do you do these changes with a script?
No, since (as you pointed out many times), the use of `errexit'
shellflag can cause portability problems if not done carefully.
So I prefer manual editing and (more or less) careful visual
inspection.
> If not, then why such whitespace changes?
Mostly absent-mindness.
> It's not like there is any consistency in
> spacing there in the current code.
Definitely right :-)
> (I'm asking because I actually had to look three times to ensure
> I didn't overlook a non-whitespace change.)
Yes, that might be pretty annoying, and might end up making review
more difficult. I'll try to be more careful in the future.
Thanks,
Stefano