automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fixed uncorrectly ordered ChangeLog entries.


From: Ralf Wildenhues
Subject: Re: [PATCH] Fixed uncorrectly ordered ChangeLog entries.
Date: Sun, 23 May 2010 13:59:27 +0200
User-agent: Mutt/1.5.20 (2009-10-28)

* Stefano Lattarini wrote on Tue, May 11, 2010 at 12:16:39PM CEST:
> Oops.  There was a typo in the git commit message :-(
> An amended patch is attached.

> From 3025ae248e87ff6fa6c6bf9d64d6ee4f17246744 Mon Sep 17 00:00:00 2001
> From: Stefano Lattarini <address@hidden>
> Date: Sun, 9 May 2010 15:06:25 +0200
> Subject: [PATCH] Fixed uncorrectly ordered ChangeLog entries.

> -2010-04-22  Stefano Lattarini  <address@hidden>
> -
> -     Minor improvements in comments of test `silent3.test'.
> -     * tests/silent3.test: Tell to keep it in sync with `silent9.test'
> -     too.
> -
> -2010-04-25  Ralf Wildenhues  <address@hidden>
> -
>       testsuite: ensure verbose printing of captured output.
>       * tests/acloca14.test, tests/acloca18.test, tests/aclocal.test,
>       tests/fort2.test, tests/help.test, tests/missing3.test,
>       tests/missing6.test: Print captured stdout or stderr before
>       grepping it.
>  
> +2010-04-22  Stefano Lattarini  <address@hidden>
> +
> +     Minor improvements in comments of test `silent3.test'.
> +     * tests/silent3.test: Tell to keep it in sync with `silent9.test'
> +     too.
> +

Well, that's once again difference between the author date of the patch
and the commit date.  The patches were committed on 2010-04-25, and GCS
generally recommend using the commit date.  I prefer that to keep the
order in the ChangeLog as consistent as possible with the commit order.
Of course, that's not always possible in the presence of work done on
branches.

I'm applying this patch instead in your name, to maint.

Cheers,
Ralf

commit 5eb0bf21fba328450fbf41d19ed2e592ba4506f2
Author: Stefano Lattarini <address@hidden>
Date:   Sun May 23 13:58:44 2010 +0200

    Fix a ChangeLog commit date, for consistent order.
    
    Signed-off-by: Ralf Wildenhues <address@hidden>

diff --git a/ChangeLog b/ChangeLog
index 7010e85..a9562c2 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -8,7 +8,7 @@
        * automake.in (read_main_am_file): Call variables_dump, not
        macros_dump.  Print actual error before list of variables.
 
-2010-04-22  Stefano Lattarini  <address@hidden>
+2010-04-25  Stefano Lattarini  <address@hidden>
 
        Minor improvements in comments of test `silent3.test'.
        * tests/silent3.test: Tell to keep it in sync with `silent9.test'



reply via email to

[Prev in Thread] Current Thread [Next in Thread]