automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Avoid possible false negatives in cond46.test.


From: Stefano Lattarini
Subject: Re: [PATCH] Avoid possible false negatives in cond46.test.
Date: Sun, 11 Apr 2010 21:04:55 +0200
User-agent: KMail/1.12.1 (Linux/2.6.30-2-686; KDE/4.3.2; i686; ; )

At Sunday 11 April 2010, Ralf Wildenhues <address@hidden> 
wrote:
> * Stefano Lattarini wrote on Fri, Apr 09, 2010 at 02:19:32AM CEST:
> > Avoid possible false negatives in cond46.test.
> >
> > * tests/cond46.test: Enable shell `errexit' flag (and bumped
> > copyright years).  Due to this change, the testcase should now
> > fail on unexpected failures in calls to $ACLOCAL/$AUTOMAKE (whose
> > outcomes were previously unchecked), and on failures in grepping
> > the expected diagnostic in Automake stderr.
> 
> Thanks, applied to maint.  Please let's not get overly verbose in
>  the log entry.
> 
How'd you suggest to shorten the log entry above, while keeping it 
meaningful?  I thought of this:

  * tests/cond46.test: Enable shell `errexit' flag (and bumped
    copyright years).  Due to this change, the testcase should now
    fail on unexpected failures of aclocal/automake, and on failures
    in grepping the expected diagnostic in Automake stderr.

but it's doesn't seem *that* shorter (even if, in hindsight, it's 
somewhat clearer).  Would this have been enough?

Another possibility would be to go for high terseness, like:
  
  * tests/cond46.test: Enable shell `errexit' flag (and bumped
    copyright years).  This prevents possible false negatives.

but this seems less clear and useful to me.  However, if you think 
that high terseness is better than high verbosity, I could aim for the 
former when in doubt.

Thanks,
     Stefano




reply via email to

[Prev in Thread] Current Thread [Next in Thread]