[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/4] Slighty improve tests acoutbs.test and acoutbs2.test.
From: |
Stefano Lattarini |
Subject: |
Re: [PATCH 4/4] Slighty improve tests acoutbs.test and acoutbs2.test. |
Date: |
Fri, 11 Dec 2009 15:53:04 +0100 |
User-agent: |
KMail/1.12.1 (Linux/2.6.30-2-686; KDE/4.3.2; i686; ; ) |
> In this patch, I extend the test acoutbs2.test, mostly to be sure
> that I correctly understood the semantic of its checks when I did
> the previous change. For consistency, I also extend in a similar
> fashion the test acoutbs.test, as it's very similar to
> acoutbs2.test (both in code and in the tested sematic).
>
Sorry, I forgot to updated copyright years in the changes scripts, and
I also made stupd typos in ChangeLog entry and in git log message.
An updated patch is attached.
From a20bf194084559edc94a093c0dcae4823102f8c9 Mon Sep 17 00:00:00 2001
From: Stefano Lattarini <address@hidden>
Date: Fri, 11 Dec 2009 13:30:40 +0100
Subject: [PATCH 4/4] Slighty improve tests acoutbs.test and acoutbs2.test.
* tests/acoutbs2.test: Enable `errexit' shell flag. Check that
autoconf and configure work, that the file `zot' is created by
configure, and that no file containing a backslash in its name is
created.
* tests/acoutbs.test: Likewise, plus updated copyright years.
---
ChangeLog | 9 +++++++++
tests/acoutbs.test | 14 ++++++++++++--
tests/acoutbs2.test | 12 +++++++++++-
3 files changed, 32 insertions(+), 3 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index e42d72d..6490bdc 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,14 @@
2009-12-11 Stefano Lattarini <address@hidden>
+ Slighty improve tests acoutbs.test and acoutbs2.test.
+ * tests/acoutbs2.test: Enable `errexit' shell flag. Check that
+ autoconf and configure work, that the file `zot' is created by
+ configure, and that no file containing a backslash in its name is
+ created.
+ * tests/acoutbs.test: Likewise, plus updated copyright years.
+
+2009-12-11 Stefano Lattarini <address@hidden>
+
Fix test acoutbs2.test.
* tests/acoutbs2: In the generated configure.in: add proper calls
to AC_INIT and AM_INIT_AUTOMAKE, and remove explicit definition of
diff --git a/tests/acoutbs.test b/tests/acoutbs.test
index 0f5eb48..ce1fcf5 100755
--- a/tests/acoutbs.test
+++ b/tests/acoutbs.test
@@ -1,5 +1,5 @@
#!/bin/sh
-# Copyright (C) 1996, 2000, 2001, 2002 Free Software Foundation, Inc.
+# Copyright (C) 1996, 2000, 2001, 2002, 2009 Free Software Foundation, Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
@@ -19,6 +19,8 @@
. ./defs || Exit 1
+set -e
+
cat > configure.in << 'END'
AC_INIT
AM_INIT_AUTOMAKE(nonesuch, nonesuch)
@@ -29,5 +31,13 @@ END
: > Makefile.am
: > zot.in
-$ACLOCAL || Exit 1
+$ACLOCAL
+$AUTOCONF
$AUTOMAKE
+
+./configure
+
+test -f zot || Exit 1
+ls -a | grep '\\' && Exit 1
+
+:
diff --git a/tests/acoutbs2.test b/tests/acoutbs2.test
index 8af1be2..6fda626 100755
--- a/tests/acoutbs2.test
+++ b/tests/acoutbs2.test
@@ -19,6 +19,8 @@
. ./defs || Exit 1
+set -e
+
cat > configure.in << 'END'
AC_INIT
AM_INIT_AUTOMAKE(nonesuch, nonesuch)
@@ -34,5 +36,13 @@ END
: > Makefile.am
: > zot.in
-$ACLOCAL || Exit 1
+$ACLOCAL
+$AUTOCONF
$AUTOMAKE
+
+./configure
+
+test -f zot || Exit 1
+ls -a | grep '\\' && Exit 1
+
+:
--
1.6.5
- [PATCH 0/4] Testsuite: check the list of test scripts, Stefano Lattarini, 2009/12/11
- [PATCH 1/4] maintainer-check: check consistency of list of test scripts., Stefano Lattarini, 2009/12/11
- [PATCH 2/4] Add forgotten test scripts to $(TESTS), Stefano Lattarini, 2009/12/11
- [PATCH 3/4] Fix test acoutbs2.test, Stefano Lattarini, 2009/12/11
- [PATCH 4/4] Slighty improve tests acoutbs.test and acoutbs2.test., Stefano Lattarini, 2009/12/11
- Re: [PATCH 4/4] Slighty improve tests acoutbs.test and acoutbs2.test.,
Stefano Lattarini <=
- Re: [PATCH 0/4] Testsuite: check the list of test scripts, Stefano Lattarini, 2009/12/25