Re: Introduce and use the %KEY?TRUE:FALSE% template token

[Benoit Sigoure]

On Nov 19, 2007, at 6:26 AM, Akim Demaille wrote:

> I would like to work a bit on the install targets, and before
> starting I felt that some means to factor and to make template
> files more readable were lacking.  I propose the following.
>
> <ternary.patch>

> diff --git a/automake.in b/automake.in
> index 3b96f1b..8893b84 100755
> --- a/automake.in
> +++ b/automake.in
> @@ -11,7 +11,7 @@ eval 'case $# in 0) exec @PERL@ -S "$0";; *) exec  
> @PERL@ -S "$0" "$@";; esac'
>  # This program is free software; you can redistribute it and/or  
> modify
>  # it under the terms of the GNU General Public License as  
> published by
> -# the Free Software Foundation; either version 3, or (at your option)
> +# the Free Software Foundation; either version 2, or (at your option)

Weird change :)

By the way, I know you use Apple Mail (so do I), which sucks when  
sending patches because it can't be arsed to set the proper mime type  
(it uses Content-Type: application/octet-stream) and you can't  
override it.  Also, you can't specify that the attachment is viewable  
inline (which is normal since it gets the mime type wrong).  Anyways,  
this is annoying to review the patch so I suggest that you do a  
commit in your local Git tree (git commit) and then create the patch  
(git format-patch HEAD~1..) and then use Git to send the patch (git  
send-email --to address@hidden *.patch).  If you feel like  
adding comments to your patch, edit the .patch generated by git- 
format-patch and add it in between the `---' and the diffstat.  If  
you want to remove that commit, you can then git reset --hard HEAD~1.

Cheers,

--
Benoit Sigoure aka Tsuna
EPITA Research and Development Laboratory

PGP.sig
Description: This is a digitally signed message part