Re: support for lzma in automake?

[Jim Meyering]

Ralf Wildenhues <address@hidden> wrote:

Hi Ralf!

> A general question, just in case you happen to know: does lzma support
> recovery of broken files a la bzip2recover?  I could not find anything
> about this on their web site.

Not yet.
But my limited exposure to the author make me think
it's on the to-do list.

> * Jim Meyering wrote on Sun, Oct 07, 2007 at 11:44:55AM CEST:
>>
>> [BTW, if there's interest (ha!) I will set up a read-only git mirror
>>  on sourceware.org of the primary automake-cvs repository there.
>>  Lvm2 and device-mapper were the first test subjects there:
>>   http://sources.redhat.com/git/gitweb.cgi
>>  ]
>
> Me, too.  I'd even prefer a move to git as primary source and let CVS be
> the mirror, if Alexandre doesn't disagree, and in case CVS branches are

Great!

> properly imported.  AFAICS they aren't present in the current read-ony
> mirror; this however is rather important for Automake.

That's fixed now.
I'd pushed only "master".  Now I've pushed everything.

...
>> I'll commit it in a couple days.
>
> Thanks, please do, and consider the following nits:
>
> In the ChangeLog entry, you could mention that Karl suggested this
> feature.

Good point.

>> Here's the patch.  It works for coreutils.
>> It also passed "make check", well at least up to "pr401.test"
>> where I interrupted it.
>
> I assume the check passed with `lzma' and `unlzma' installed?  FWIW,

Right.

> I don't have these, and it does correctly skip without these programs,
> and the rest of the suite tests fine as well.  ;-)
>
>> --- a/doc/automake.texi
>> +++ b/doc/automake.texi
>> @@ -8082,6 +8082,11 @@ frequently smaller than gzipped archives.
>>  Generate a gzip tar archive of the distribution.
>>  @trindex dist-gzip
>>
>> address@hidden @code{dist-lzma}
>> +Generate a lzma tar archive of the distribution.  lzma archives are
>> +frequently smaller than bzipped archives.
>
> "bzip2'ed"?  I have no idea which spelling would be better.

Yeah, I hesitated there :-)
How about "@command{bzip2}-compressed"?

>> diff --git a/tests/defs.in b/tests/defs.in
>> index 78cf37a..f2887a6 100644
>> --- a/tests/defs.in
>> +++ b/tests/defs.in
>> @@ -162,6 +162,10 @@ do
>>        echo "$me: running $CC -V -help"
>>        ( $CC -V -help ) || exit 77
>>        ;;
>> +    lzma)
>> +      echo "$me: running lzma --version"
>> +      ( lzma --version ) || exit 77
>> +      ;;
>>      makedepend)
>>        echo "$me: running makedepend -f-"
>>        ( makedepend -f- ) || exit 77
>
> This change is redundant, you can just omit it.

Will do.  Thanks.

>> diff --git a/tests/lzma.test b/tests/lzma.test
>> new file mode 100755
>> index 0000000..cbdaf20
>> --- /dev/null
>> +++ b/tests/lzma.test
>> @@ -0,0 +1,45 @@
>> +#! /bin/sh
>> +# Copyright (C) 2007  Free Software Foundation, Inc.
> [...]
>
> I assume this file is derived from nogzip.test.  In this case, it should
> also contain 2003 as copyright year.

Ok

> [...]
>> +AC_INIT([nogzip], [1.0])
> [...]
>> +    test $(DIST_ARCHIVES) = nogzip-1.0.tar.lzma

Done.

> Please name the thing after the test file, lzma, so that it's easy to
> match VERBOSE=yes test output with the corresponding test.

Thanks for the review!