automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: mdate-sh borks on uid/gid containing a space


From: Dave Korn
Subject: RE: mdate-sh borks on uid/gid containing a space
Date: Thu, 29 Mar 2007 00:40:12 +0100

On 29 March 2007 00:26, Ralf Wildenhues wrote:

> Hi Dave,
> 
> * Dave Korn wrote on Wed, Mar 28, 2007 at 07:01:59PM CEST:
>> 
>>   As the subject line says, mdate-sh can get badly confused if there are
>> spaces in the textual version of the uid or gid.
> 
> Yep:
>
<http://thread.gmane.org/gmane.comp.sysutils.automake.patches/2730/focus=2740>
> Eric's patch seems to indicate that line 92 needs changed, too.
> (I haven't tested any on w32.)

  I don't quite understand that myself; ISTM that having -n in $ls_command
should do the job for both cases.
 
> It would surely be helpful to know whether we can assume -n to work
> portably and avoid the test (we test for -L which is POSIX, too).

  Well, to be fair it's a lot safer to test for it, and since this script may
only be invoked once in a very rare while, I don't suppose it's that important
to optimise every last bit out of it.  I'd like to hear Eric's rationale about
the line 92 change, but I reckon his patch is probably safer.

  He remembered to update the scriptversion and copyright lines, too!  :)

    cheers,
      DaveK
-- 
Can't think of a witty .sigline today....





reply via email to

[Prev in Thread] Current Thread [Next in Thread]