automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: mdate-sh vs. evil user/group names


From: Ralf Wildenhues
Subject: Re: mdate-sh vs. evil user/group names
Date: Wed, 28 Mar 2007 17:59:06 +0200
User-agent: Mutt/1.5.14 (2007-03-22)

Hi Eric,

Apologies for the delay.

* Eric Blake wrote on Thu, Mar 01, 2007 at 11:24:14PM CET:
> mdate-sh fails miserably in the presence of user/group names that contain 
> spaces (bad practice, but particularly common on cygwin).
[...]
> OK to apply this patch?

This patch looks ok for HEAD and branch-1-10, if `ls -n' works
reasonably on Cygwin and MinGW.  (What are the numbers that are
returned, BTW?)

It would be even better if it came with a test to ensure correct
functioning of the script, as far as portably possible.  For example,
it could test that three words are output, and that day and year are
numeric.  (As usual, I can write the test, but if you do it, then it
will be done more quickly ;-)

Cheers,
Ralf

> 2007-03-01  Eric Blake  <address@hidden>
> 
>       * lib/mdate-sh (ls_command): Use -n when available to avoid
>       problems with spaces in user/group names.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]