automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: improved Automake test for file names with funny characters


From: Alexandre Duret-Lutz
Subject: Re: improved Automake test for file names with funny characters
Date: Tue, 13 Sep 2005 22:54:19 +0200
User-agent: Gnus/5.110003 (No Gnus v0.3) Emacs/22.0.50 (gnu/linux)

>>> "PE" == Paul Eggert <address@hidden> writes:

 PE> Following up on your response to
 PE> <http://lists.gnu.org/archive/html/automake-patches/2005-07/msg00024.html>:

 PE> Alexandre Duret-Lutz <address@hidden> writes:

 >> I think some of these changes need to be synced with
 >> mkinstalldirs and vice-versa.

 PE> I thought mkinstalldirs was obsolete now?  Do we need to
 PE> continue to maintain it?

gettext still uses it.  But I agree: let's forget about it, and let
the remaining users to fix the problems they encounter if they can't switch
to `install -d' for some reason.

 PE> What changes in mkinstalldirs need to be merged into install-sh?
 PE> (Presumably these can be folded in after the changes below are installed.)

I'll have to check.  I think I noticed that mkinstalldirs was
trying `mkdir -p' before constructing the subdirectories one by
one, while install-sh wasn't even attempting `mkdir -p'.  But your
patch addresses this already, doesn't it?

[...]

 PE> In the revised patch enclosed below, I'll add some commentary about
 PE> this to help explain it.

Thanks all lot!  Could you remember to bump install-sh's
$scriptversion before you commit it ?

 >> It does not seem to be fixed on platforms where "mkdir -p" does
 >> not work.  (I'm concerned by the spurious report about test
 >> suite failures more than by the missing feature on these
 >> system.)

 PE> That should be fixed now; please see below.

 >> Does Stephan's patch for quoting $@ before eval look right to you?

 PE> No, because echo mishandles some path names.  However, there is
 PE> a better fix for the IFS problem in general, as discussed in
 PE> <http://lists.gnu.org/archive/html/autoconf-patches/2005-08/msg00074.html>.
 PE> The revised patch below incorporates this idea into install-sh.

Thanks for the link.  I didn't know about `set -f'.
-- 
Alexandre Duret-Lutz





reply via email to

[Prev in Thread] Current Thread [Next in Thread]