automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 13 of 477 tests failed


From: Alexandre Duret-Lutz
Subject: Re: 13 of 477 tests failed
Date: Sat, 07 Feb 2004 14:45:16 +0100
User-agent: Gnus/5.1003 (Gnus v5.10.3) Emacs/21.3.50 (gnu/linux)

>>> "Werner" == Werner John <address@hidden> writes:

 Werner> Alexandre Duret-Lutz writes:
 >> 
 >> No.  Please run the above command from the tests/ subdirectory, not
 >> from the top level directory.  Sorry I forgot to say that.

 Werner> ok, here you go..

Thank you.
I'm installing the following patch on HEAD and branch-1-8.
This should fix 11 of the 13 failures you reported.

2004-02-07  Alexandre Duret-Lutz  <address@hidden>

        * aclocal.in (rel2abs): New function.
        (scan_configure_dep): Use rel2abs instead of File::Spec->rel2abs,
        the later does was introduced in Perl 5.6 so using it breaks with
        Perl 5.005.
        Report from Werner John.

Index: NEWS
===================================================================
RCS file: /cvs/automake/automake/NEWS,v
retrieving revision 1.256.2.26
diff -u -r1.256.2.26 NEWS
--- NEWS        1 Feb 2004 18:07:06 -0000       1.256.2.26
+++ NEWS        7 Feb 2004 13:39:40 -0000
@@ -11,7 +11,7 @@
     in packages configured with
       ./configure --prefix '/c/Program Files'
 
-  - Fix the depfils output so it works with GNU sed (<4.1) even when
+  - Fix the depfiles output so it works with GNU sed (<4.1) even when
     POSIXLY_CORRECT is set.
 
   - Do not AC_SUBST(LIBOBJS) in AM_WITH_REGEX.  This macro was unusable
@@ -22,6 +22,16 @@
 
   - Do not assume that users override _DEPENDENCIES in all conditions
     where Automake will try to define them.
+
+* Bugs introduced by 1.8:
+
+  - In some situations (hand-written `m4_include's), aclocal would
+    call the `File::Spec->rel2abs' method, which was only introduced
+    in Perl 5.6.  This new version reestablish support Perl 5.005.
+
+    It is likely that the next major Automake releases will require at
+    least Perl 5.6.  Consider upgrading your development environment
+    if you are still using the five-year-old Perl 5.005.
 
 * New sections in manual:
 
Index: THANKS
===================================================================
RCS file: /cvs/automake/automake/THANKS,v
retrieving revision 1.230.2.9
diff -u -r1.230.2.9 THANKS
--- THANKS      1 Feb 2004 18:07:06 -0000       1.230.2.9
+++ THANKS      7 Feb 2004 13:39:40 -0000
@@ -240,6 +240,7 @@
 Ulrich Drepper         address@hidden
 Václav Haisman         address@hidden
 Vadim Zeitlin          address@hidden
+Werner John            address@hidden
 Werner Koch            address@hidden
 William S Fulton       address@hidden
 Yann Droneaud          address@hidden
Index: aclocal.in
===================================================================
RCS file: /cvs/automake/automake/aclocal.in,v
retrieving revision 1.96.2.3
diff -u -r1.96.2.3 aclocal.in
--- aclocal.in  6 Jan 2004 22:08:30 -0000       1.96.2.3
+++ aclocal.in  7 Feb 2004 13:39:41 -0000
@@ -41,6 +41,7 @@
 use Automake::FileUtils;
 use File::Basename;
 use File::stat;
+use Cwd;
 
 # Note that this isn't pkgdatadir, but a separate directory.
 # Note also that the versioned directory is handled later.
@@ -202,8 +203,30 @@
     &add_file ($map{$macro});
 }
 
-# scan_contents ($file)
-# --------------------------------
+# rel2abs ($file, $directory)
+# ---------------------------
+# Similar to File::Spec->rel2abs ($file, $directory), but
+# work with Perl 5.005.  (File::Spec->rel2abs is available
+# only in Perl 5.6.)
+# Remove this once we require 5.6.
+sub rel2abs ($$)
+{
+  my ($file, $dir) = @_;
+  if (! File::Spec->file_name_is_absolute ($file))
+    {
+      $dir = cwd () . "/$dir"
+       unless File::Spec->file_name_is_absolute ($dir);
+      $file = "$dir/$file";
+    }
+  $file = File::Spec->canonpath ($file);
+  return $file;
+}
+
+# scan_configure_dep ($file)
+# --------------------------
+# Scan a configure dependency (configure.ac, or separate m4 files)
+# for uses of know macros and AC_REQUIREs of possibly unknown macros.
+# Recursively scan m4_included files.
 my %scanned_configure_dep = ();
 sub scan_configure_dep ($)
 {
@@ -253,7 +276,7 @@
 
   add_macro ($_) foreach (@rlist);
   my $dirname = dirname $file;
-  &scan_configure_dep (File::Spec->rel2abs ($_, $dirname)) foreach (@ilist);
+  &scan_configure_dep (rel2abs ($_, $dirname)) foreach (@ilist);
 }
 
 # Add a file to output.

-- 
Alexandre Duret-Lutz





reply via email to

[Prev in Thread] Current Thread [Next in Thread]