automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: FYI: s/$cygnus_mode/$options{'cygnus'}/


From: Alexandre Duret-Lutz
Subject: Re: FYI: s/$cygnus_mode/$options{'cygnus'}/
Date: Tue, 8 Jul 2003 10:46:05 +0200

On Tue, Jul 08, 2003 at 10:10:16AM +0200, Akim Demaille wrote:
> -    %options = ();
> +    %options =
> +      (
> +       # TRUE if --cygnus seen.
> +       'cygnus' => 0,
> +      );
[...]
> -  $options{'no-installinfo'} = $cygnus_mode;
> -  $options{'no-dependencies'} = $cygnus_mode;
> +  $options{'no-installinfo'} = $options{'cygnus'};
> +  $options{'no-dependencies'} = $options{'cygnus'};
[...]
> +  my %cli_options =
>      (
>       'libdir:s'      => \$libdir,
>       'gnu'           => sub { &set_strictness ('gnu'); },
>       'gnits'                 => sub { &set_strictness ('gnits'); },
> -     'cygnus'                => \$cygnus_mode,
> +     'cygnus'                => \$options{'cygnus'},

I've recently changed most (I thought all) of the %options values to
hold a Locations.  Especially, gnu_check_standards uses
$options{'no-installinfo'} as a Location.  (Obviously I forgot to
update these $cygnus_mode assignments.)  Anyway, wouldn't it look
better to use $options{'cygnus'} like the other options?  An option is
turned off if its key does not exist, and otherwise it contains the
Location of its definition.  But what is the Location of a command
line option?  An empty one?




reply via email to

[Prev in Thread] Current Thread [Next in Thread]