automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

FYI: fix undefined warnings for recursively defined variables


From: Alexandre Duret-Lutz
Subject: FYI: fix undefined warnings for recursively defined variables
Date: Wed, 02 Jul 2003 23:57:45 +0200
User-agent: Gnus/5.1002 (Gnus v5.10.2) Emacs/21.3 (gnu/linux)

I'm checking this in.  I'm currently working on a new scheme to test
Automake's exit codes which should allow to distinguish Perl's errors
from Automake's error, and I discovered that issue by running
cond20.test manually.

2003-07-02  Alexandre Duret-Lutz  <address@hidden>

        * lib/Automake/Variable.pm (_traverse_variable_recursively_worker):
        Do not return undef when a variable is recursively defined, this
        causes warnings all over the place.  Return the empty string instead.

Index: lib/Automake/Variable.pm
===================================================================
RCS file: /cvs/automake/automake/lib/Automake/Variable.pm,v
retrieving revision 1.6
diff -u -r1.6 Variable.pm
--- lib/Automake/Variable.pm    30 Jun 2003 06:35:55 -0000      1.6
+++ lib/Automake/Variable.pm    2 Jul 2003 21:49:23 -0000
@@ -1476,7 +1476,7 @@
   if (defined $_vars_scanned{$var})
     {
       err_var $var, "variable `" . $var->name() . "' recursively defined";
-      return undef;
+      return "";
     }
   $_vars_scanned{$var} = 1;
 

-- 
Alexandre Duret-Lutz





reply via email to

[Prev in Thread] Current Thread [Next in Thread]