automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: automake 1.7.2b, tests/depcomp3.test and DJGPP


From: Alexandre Duret-Lutz
Subject: Re: automake 1.7.2b, tests/depcomp3.test and DJGPP
Date: Wed, 19 Feb 2003 21:08:55 +0100
User-agent: Gnus/5.090008 (Oort Gnus v0.08) Emacs/21.2 (i386-pc-linux-gnu)

>>> "Richard" == Richard Dawe <address@hidden> writes:

[...]

 Richard> How about the change below for the distcheck target?
 Richard> This makes all the tests listed above pass for me. I
 Richard> haven't touched anything in tests/.

That looks great.  I've installed the appended patch.

 Richard> Note that there can be more than 26 DOS drives, so
 Richard> matching alphabetic characters isn't enough. That's
 Richard> why I've used [^:\\/] below, to match the first
 Richard> character of the filename.

Six years ago, when I was still a DOS user, I used to amaze my
friends by showing them my list of drive letters (A,C...M,Q,U,V,
if I recall correct).  If I knew I could have had more than 26
letters I'd certainly have tried.  Out of curiosity, what comes
after Z?

FWIW the [a-zA-Z] test is wired in other places like depcomp.

[...]


2003-02-19  Richard Dawe  <address@hidden>

        * lib/am/distdir.am (distcheck): Strip any leading DOS drive
        from dc_install_base.

Index: lib/am/distdir.am
===================================================================
RCS file: /cvs/automake/automake/lib/am/distdir.am,v
retrieving revision 1.40.2.3
diff -u -r1.40.2.3 distdir.am
--- lib/am/distdir.am   13 Jan 2003 14:23:22 -0000      1.40.2.3
+++ lib/am/distdir.am   19 Feb 2003 19:46:41 -0000
@@ -1,5 +1,5 @@
 ## automake - create Makefile.in from Makefile.am
-## Copyright (C) 2001, 2002 Free Software Foundation, Inc.
+## Copyright (C) 2001, 2002, 2003  Free Software Foundation, Inc.
 
 ## This program is free software; you can redistribute it and/or modify
 ## it under the terms of the GNU General Public License as published by
@@ -303,7 +303,10 @@
        mkdir $(distdir)/_inst
 ## Undo the write access.
        chmod a-w $(distdir)
-       dc_install_base=`$(am__cd) $(distdir)/_inst && pwd` \
+## Compute the absolute path of `_inst'.  Strip any leading DOS drive
+## to allow DESTDIR installations.  Otherwise $(DESTDIR)$(prefix) would
+## expand to c:/temp/am-dc-5668/c:/src/package/package-1.0/_inst.
+       dc_install_base=`$(am__cd) $(distdir)/_inst && pwd | sed -e 
's,^[^:\\/]:[\\/],/,'` \
 ## We will attemp a DESTDIR install in $dc_destdir.  We don't
 ## create this directory under $dc_install_base, because it would
 ## create very long directory names.



-- 
Alexandre Duret-Lutz





reply via email to

[Prev in Thread] Current Thread [Next in Thread]