Re: Automake::Conditional::invert

[Raja R Harinath]

Hi,

Alexandre Duret-Lutz <address@hidden> writes:

>>>> "Raja" == Raja R Harinath <address@hidden> writes:
>
>  Raja> Alexandre Duret-Lutz <address@hidden> writes:
>  >> Index: automake.in
>  >> ## ------------------------------ ##
>  >> ## Handling the condition stack.  ##
>  >> ## ------------------------------ ##
>  >> @@ -5957,7 +5942,7 @@
>  >> 
>  >> $cond = "${cond}_TRUE"
>  >> unless $cond =~ /^TRUE|FALSE$/;
>  >> -  $cond = condition_negate ($cond)
>  >> +  $cond = Automake::Conditional::condition_negate ($cond)
>  >> if $negate;
>
>  Raja> This pattern should probably be converted to a function
>  Raja> make_conditional_string ($cond, $negate);
>  Raja> Or even 'make_conditional' and change @cond_stack to store real
>  Raja> A::Conditional object references.
>
> Or even... let's move all this into a ConditionalStack class.

Nah.  That's too heavyweight.  You just need a small helper function
in 'automake.in' to encapsulate the format in which it talks to
Automake::Conditional -- that's all.  On further reading, @cond_stack
seems fine in it's current use.

>  Raja> Can we kill $self->permutations then :-)
>
> It is still called from &variable_conditions_recursive and
> &variable_conditions_recursive_sub, although I'm not sure if
> it's legitimate.

OK.

- Hari
-- 
Raja R Harinath ------------------------------ address@hidden