automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: FYI: move TRUE, FALSE, & variable_conditions_reduce to Conditional.p


From: Raja R Harinath
Subject: Re: FYI: move TRUE, FALSE, & variable_conditions_reduce to Conditional.pm
Date: Wed, 13 Nov 2002 18:26:30 -0600
User-agent: Gnus/5.090008 (Oort Gnus v0.08) Emacs/21.3.50 (i686-pc-linux-gnu)

Hi,

Alexandre Duret-Lutz <address@hidden> writes:

>>>> "adl" == Alexandre Duret-Lutz <address@hidden> writes:
>
>  adl> I'm installing this.
>
> Hmm no, I forgot to update cond12.test.  
> I'm installing this instead.
>
> 2002-11-13  Alexandre Duret-Lutz  <address@hidden>
>
>       * automake.in: Don't declare TRUE and FALSE, import them from
>       Automake::Conditional.
>       * lib/Automake/Conditional.pm (TRUE, FALSE): New constants.
>       (new): Simplify using FALSE.
>       (reduce): New function, moved from ...
>       * automake.in (variable_conditions_reduce): ... here.
>       (variable_conditions_recursive_sub, invert_conditions):
>       Adjust calls to Automake::Conditional::reduce.
>       * tests/cond12.test: Adjust to use Automake::Conditional.
[snip]
> Index: tests/cond12.test
> ===================================================================
[snip]
> -# Test behaviour of variable_conditions_reduce()
> -# This checks the result of variable_conditions_reduce() for a wide variety
> -# of cases.
> +# This checks the result of Automake::Conditional::reduce() for
> +# a wide variety of cases.

Since this is purely a test of Automake::Conditional, should it be
moved into 'lib/Automake'?

Is it worth having an independent test directory for the Perl modules
alone?  Maybe even using Perl's own testing infrastructure.

- Hari
-- 
Raja R Harinath ------------------------------ address@hidden




reply via email to

[Prev in Thread] Current Thread [Next in Thread]