Re: FYI: tests depends on ./defs

[Alexandre Duret-Lutz]

>>> "adl" == Alexandre Duret-Lutz <address@hidden> writes:

[...]

 Raja> I'd prefer

 Raja> check_SCRIPTS = defs

 Raja> as a somewhat cleaner way of expressing this.

 adl> You didn't say why :)

 adl> I'm not overly fond of hiding dependencies to make: the more
 adl> make knows about dependencies, the more reliable the build is.

Scratch that.  You are right.  My lucubrartions are completly
void.  Akim corrected me: make records build dependencies, not
run-time dependencies.

Moreover $(TESTS) are distributed while defs isn't, so the
former should never depends on the latter.  (Likewise for all
the borken examples I posted.)

I'm checking in your fix.  Thanks!

2002-09-10  Alexandre Duret-Lutz  <address@hidden>

        * tests/Makefile.am ($(TESTS)): Replace by ...
        (check_SCRIPTS): ... this.
        Suggested by Raja R Harinath.

Index: tests/Makefile.am
===================================================================
RCS file: /cvs/automake/automake/tests/Makefile.am,v
retrieving revision 1.434
diff -u -r1.434 Makefile.am
--- tests/Makefile.am   9 Sep 2002 08:56:56 -0000       1.434
+++ tests/Makefile.am   10 Sep 2002 09:43:07 -0000
@@ -424,7 +424,7 @@
 EXTRA_DIST = ChangeLog-old $(TESTS)
 
 # Each test case depends on defs.
-$(TESTS): defs
+check_SCRIPTS = defs
 
 distclean-local:
        -rm -rf testSubDir
Index: tests/Makefile.in
===================================================================
RCS file: /cvs/automake/automake/tests/Makefile.in,v
retrieving revision 1.559
diff -u -r1.559 Makefile.in
--- tests/Makefile.in   9 Sep 2002 08:56:56 -0000       1.559
+++ tests/Makefile.in   10 Sep 2002 09:43:07 -0000
@@ -514,6 +514,9 @@
 
 
 EXTRA_DIST = ChangeLog-old $(TESTS)
+
+# Each test case depends on defs.
+check_SCRIPTS = defs
 subdir = tests
 mkinstalldirs = $(SHELL) $(top_srcdir)/lib/mkinstalldirs
 CONFIG_CLEAN_FILES = defs
@@ -640,6 +643,7 @@
          fi; \
        done
 check-am: all-am
+       $(MAKE) $(AM_MAKEFLAGS) $(check_SCRIPTS)
        $(MAKE) $(AM_MAKEFLAGS) check-TESTS
 check: check-am
 all-am: Makefile
@@ -723,9 +727,6 @@
        mostlyclean mostlyclean-generic pdf pdf-am ps ps-am uninstall \
        uninstall-am uninstall-info-am
 
-
-# Each test case depends on defs.
-$(TESTS): defs
 
 distclean-local:
        -rm -rf testSubDir

-- 
Alexandre Duret-Lutz