Re: dirlist

[Charles Wilson]

Alexandre Duret-Lutz wrote:

> Index: tests/dirlist.test
> ===================================================================
> RCS file: /cvs/automake/automake/tests/dirlist.test,v
> retrieving revision 1.1
> diff -u -r1.1 dirlist.test
> --- tests/dirlist.test  31 Jul 2002 19:58:26 -0000      1.1
> +++ tests/dirlist.test  1 Aug 2002 22:21:46 -0000


[...]


> +$ACLOCAL
>  grep 'DEFUN.*AM_INIT_GUILE_MODULE' aclocal.m4


shouldn't there be an '|| exit 1' on the end of this line?  Otherwise, 
if you fail this greptest, but pass the next one, then your exit code is 
0 (pass); but it should be 1 (fail).  Or am I missing something?

> +
> +# This bug can occur only when we do a VPATH build of Automake
> +# (beause of the `-I' passed to aclocal in tests/defs) but it's
> +# ok because this is what `make distcheck' does.
> +grep 'I should not be included' aclocal.m4 && exit 1
> +
> +:


--Chuck