Re: aclocal.m4-version-check.patch

[Tom Tromey]

>>>>> "adl" == Alexandre Duret-Lutz <address@hidden> writes:

adl> I'm ambivalent about issuing a warning or an error on version
adl> mismatch.

Like Akim, I'm fine with an error.  I've been trying to think of
failure modes, but I can't think of one that can't be fixed by simply
running aclocal.

adl> +m4data_DATA = amversion.m4 as.m4 auxdir.m4 ccstdc.m4 cond.m4 depend.m4 \

I don't think we want to distribute amversion.m4.  Also there's no
need to check it in.  So it should go in nodist_m4data_DATA.

adl> +# Do the substitution here, not from config.status, because the latter
adl> +# would cause amversion.m4 to be recreated identically on each
adl> +# installation (overkill).

We already do this same thing with automake itself.  I don't think it
is a big deal.

adl> +# This needs to be updated only when $(VERSION) changes, hence the
adl> +# configure.in dependency.
adl> +amversion.m4: $(srcdir)/amversion.in $(top_srcdir)/configure.in
adl> +  sed -e 's,@VERSION\@,$(VERSION),g' \
adl> +    $(srcdir)/amversion.in > amversion.tmp
adl> +  mv amversion.tmp amversion.m4

My preference is to remove this.  However, if you think we should keep
it this way, then it needs to put amversion.m4 into srcdir.

Tom