automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 2-match-extensions.patch


From: Akim Demaille
Subject: Re: 2-match-extensions.patch
Date: 14 Nov 2001 08:55:47 +0100
User-agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Artificial Intelligence)

This is a yes for your patches 1 to 4.  My only remark being:

+# accept_extensions (@EXTS)
+# -------------------------
+# Update $KNOWN_EXTENSIONS_PATTERN to recognize the extensions
+# listed @EXTS.  Extensions should contain a dot if needed.
+sub accept_extensions (@)
+{
+    my $pat = join ('|', map (quotemeta, @_));
+    if (defined $KNOWN_EXTENSIONS_PATTERN)
+    {
+        $KNOWN_EXTENSIONS_PATTERN .= "|$pat";
+    }
+    else
+    {
+        $KNOWN_EXTENSIONS_PATTERN = $pat;
+    }
+}

I would feel much better if you had a list of these patterns, and have
use this list to build

$KNOWN_EXTENSIONS_PATTERN = '(?:' 
                            . join ('|', map (quotemeta, 
                                              @known_extensions_pattern))
                            .')';

i.e., if we could use $KNOWN_EXTENSIONS_PATTERN without having to
remember it doesn't come with its parens.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]