automake-ng
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Automake-NG] [FYI] [ng] parallel-tests: define $(TEST_SUITE_LOG) in


From: Stefano Lattarini
Subject: Re: [Automake-NG] [FYI] [ng] parallel-tests: define $(TEST_SUITE_LOG) in makefile fragment
Date: Mon, 30 Jul 2012 11:28:52 +0200

On 07/30/2012 10:56 AM, Akim Demaille wrote:
> 
> Le 30 juil. 2012 à 10:23, Stefano Lattarini a écrit :
> 
>> diff --git a/lib/am/parallel-tests.am b/lib/am/parallel-tests.am
>> index 3ad7de6..116d178 100644
>> --- a/lib/am/parallel-tests.am
>> +++ b/lib/am/parallel-tests.am
>> @@ -309,6 +309,10 @@ define am.setup-test-harness-workdir
>>        && sed 's/$$/.trs/' $$workdir/bases > $$workdir/trs
>> endef
>>
>> +ifeq ($(call am.vars.is-undef,TEST_SUITE_LOG),yes)
>> +  TEST_SUITE_LOG = test-suite.log
>> +endif
> 
> What makes you chose := for some variables, and = for others?
> 
In the case of SUBDIRS, EXEEXT and TEST_SUITE_LOG, basically nothing (i.e.,
the choice is random or motivated by consistency with surrounding code or
previous usages), because the default values we assign to those variables
are literal anyway, so using '=' or ':=' makes no difference.  We might
want to finally settle on a more rational policy in the end, but that can
be left for later IMHO.

Regards,
  Stefano



reply via email to

[Prev in Thread] Current Thread [Next in Thread]