Re: [Automake-NG] [PATCH] [ng] utils: new function 'am.vars.is-undef'

[Stefano Lattarini]

On 07/28/2012 10:09 AM, Stefano Lattarini wrote:
> Hi Jim.
> 
> Good advice, as usual.  I've amended the comments and the commit message
> following all your suggestions, and pushed.
> 
Oh, and I've also squashed in the hunk below, to sanity check the new tests:

diff --git a/t/internals.tap b/t/internals.tap
index 3bb9642..91449a0 100755
--- a/t/internals.tap
+++ b/t/internals.tap
@@ -182,10 +182,10 @@ test:
        test '$(call am.util.canon,x$(comma)@$(bslash))' = 'address@hidden'
 END

-FOO_ENVIRON=ko; export FOO_ENVIRON
+FOO_ENVIRON=ok; export FOO_ENVIRON
 FOO_UNDEF=; unset FOO_UNDEF
 FOO_INDIR=; unset FOO_INDIR
-T 'am.vars.is-undef' FOO_CMDLINE=ok FOO_OVERRIDE=ko <<'END'
+T 'am.vars.is-undef' FOO_CMDLINE=ok <<'END'

 FOO_MAKEFILE_1 = ok
 FOO_MAKEFILE_2 := ok
@@ -220,6 +220,9 @@ test:
        test -z '$(call X,CC)'
        @echo EXTRA SPACES:
        test '$(call X,  FOO_UNDEF      )' = yes
+       @echo SANITY CHECKS:
+       test '$(FOO_ENVIRON)' = ok
+       test '$(FOO_CMDLINE)' = ok
 END
 unset FOO_ENVIRON


Regards,
  Stefano