automake-ng
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Automake-NG] [FYI] [ng] rename: am__newline -> am.chars.newline


From: Stefano Lattarini
Subject: Re: [Automake-NG] [FYI] [ng] rename: am__newline -> am.chars.newline
Date: Tue, 24 Jul 2012 16:03:32 +0200

On 07/24/2012 03:54 PM, Akim Demaille wrote:
> 
> Le 24 juil. 2012 à 15:40, Stefano Lattarini a écrit :
> 
>> diff --git a/lib/am/header-vars.am b/lib/am/header-vars.am
> 
> Maybe these vars should be defined elsewhere.
>
Where do you suggest?

BTW, while I'm fully open to the idea, I believe it is something that
can be left for later.  Who knows, we might even decide to put the
definitions of all auxiliary variables and functions that do not use
any '@...@' substitution in a '*.mk' file to be distributed in the
build-auxdir of the client project, and then included by all the other
generated Makefiles ...

>> index 6efad03..bf2ad73 100644
>> --- a/lib/am/header-vars.am
>> +++ b/lib/am/header-vars.am
>> @@ -52,7 +52,7 @@ am.chars.squote := '
>>
>> # A literal newline character, that does not get stripped if used
>> # at the end of the expansion of another macro.
>> -define am__newline
>> +define am.chars.newline
>>
>> $(am.chars.empty)
>> endef
>> @@ -145,7 +145,7 @@ am.make.dry-run := \
>>
>> # An empty string.  It can be very useful to "fool" the make parser w.r.t.
>> # whitespace handling, and allow us to obtain tricky semantics.  See the
>> -# definition of $(am__newline) below for a significant example.
>> +# definition of $(am.chars.newline) below for a significant example.
> 
> "below" is to be read the Australian way.
>
Nice catch; I guess that inconsistency has originated in a past code
reordering.  I will fix the comment in a follow-up.

Thanks,
  Stefano



reply via email to

[Prev in Thread] Current Thread [Next in Thread]