Re: [Automake-NG] [PATCH 3/3] [ng] dist: do not exceed command line length limits, even with many files

[Stefano Lattarini]

On 07/14/2012 05:13 PM, Akim Demaille wrote:
> 
> Le 13 juil. 2012 à 12:19, Stefano Lattarini a écrit :
> 
>> +    @while read file; do \
>> ## Always look for the file or directory to distribute in the build
>> ## directory first, in VPATH spirit.
>>        if test -f $$file || test -d $$file; then d=.; else d=$(srcdir); fi; \
>> @@ -191,7 +200,7 @@ endif %?TOPDIR_P%
>>          || cp -p $$d/$$file "$(distdir)/$$file" \
>>          || exit 1; \
>>        fi; \
>> -    done
>> +    done < $(am__dir)/address@hidden
> 
> I would write
> 
>       @< $(am__dir)/address@hidden while read file; do
>       …
>       done
> 
> but I guess that's a matter of taste.  Ack.
> 
In this case, you have better taste I guess :-).  But is the above really
portable?  I'm not sure the slightly improved readability is worth the
risk in this case.

Regards,
  Stefano