automake-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Automake-commit] [SCM] GNU Automake branch, yl-work-for-master, updated


From: Stefano Lattarini
Subject: [Automake-commit] [SCM] GNU Automake branch, yl-work-for-master, updated. v1.11-1917-gb42514b
Date: Tue, 14 Feb 2012 12:16:33 +0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU Automake".

http://git.sv.gnu.org/gitweb/?p=automake.git;a=commitdiff;h=b42514b48a5104785737cb4459e177b98d023ed7

The branch, yl-work-for-master has been updated
       via  b42514b48a5104785737cb4459e177b98d023ed7 (commit)
      from  ee29b576923c240a951b7f0d93b7cb5d6a33face (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b42514b48a5104785737cb4459e177b98d023ed7
Author: Stefano Lattarini <address@hidden>
Date:   Tue Feb 14 10:11:02 2012 +0100

    tests: truly use Lex and Yacc selected by configure
    
    When 'yacc-work' was merged into 'yl-work-for-master' in commit
    v1.11-1910-ge6c40d4 (12-02-2012), the values for $YACC and $LEX
    stopped being substituted directly by config.status, and started
    being substituted by a Makefile rule using the contents of the
    $(YACC) and $(LEX) makefile variables.
    
    Unfortunately, our configure.ac was calling AM_SUBST_NOTMAKE on
    'YACC' and 'LEX' (see commit v1.11-284-g34ca92b of 29-01-2011,
    "tests: don't define YACC and LEX in the Makefiles", for a
    rationale), so that the $(YACC) and $(LEX) in the Makefile simply
    hold the default make-provided values (that is, "yacc" and "lex"
    respectively), independently of what yacc and lex programs were
    defined at configure time.
    
    Apart from reducing coverage and creating confusion, this behaviour
    also caused spurious failures on systems lacking a yacc and/or lex
    programs.
    
    Problem reported by Peter Rosin.  References:
     <http://lists.gnu.org/archive/html/automake-patches/2012-02/msg00131.html>
     <http://lists.gnu.org/archive/html/automake-patches/2012-02/msg00132.html>
    
    * configure.ac (AM_SUBST_NOTMAKE): Don't call anymore on 'YACC' nor
    on 'LEX'.

-----------------------------------------------------------------------

Summary of changes:
 configure.ac |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/configure.ac b/configure.ac
index cb5c6e0..badf9bb 100644
--- a/configure.ac
+++ b/configure.ac
@@ -125,11 +125,6 @@ AM_RUN_LOG([$TEX --version </dev/null])
 #     configure help screen.
 AC_CHECK_PROGS([YACC], [yacc byacc 'bison -y'], [false])
 AC_CHECK_PROGS([LEX], [lex flex], [false])
-# We don't want YACC and LEX defined as make variables, otherwise the
-# values determined at configure time will override those from the
-# environment, even in the make-spawned testcases.
-AM_SUBST_NOTMAKE([YACC])
-AM_SUBST_NOTMAKE([LEX])
 
 # Generate man pages.
 AM_MISSING_PROG([HELP2MAN], [help2man])


hooks/post-receive
-- 
GNU Automake



reply via email to

[Prev in Thread] Current Thread [Next in Thread]