[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: AM_CFLAGS
From: |
Steve Robbins |
Subject: |
Re: AM_CFLAGS |
Date: |
Mon, 12 Feb 2001 16:45:10 -0500 |
User-agent: |
Mutt/1.3.12i |
On Mon, Feb 12, 2001 at 12:42:18AM -0700, Tom Tromey wrote:
> >>>>> "Alexandre" == Alexandre Oliva <address@hidden> writes:
>
> >> In the recent namespace conversation we didn't mention macros like
> >> `AM_CFLAGS'. This is an automake-specific macro which the user is
> >> allowed to set.
>
> >> How should we rename these?
>
> Alexandre> Why should we rename these? Their names look fine to me.
>
> My understanding is that autoconf prevents us from putting these names
> (AM_*) into configure.in. However, this is a perfectly reasonable
> thing to do from automake's perspective. In fact, it is probably a
> preferred approach for packages with special flags requirements and
> multiple directories.
Is it autoCONF or autoMAKE that prevents this?
I ran into a problem (see attached message) using "aclocal", but that's
an automake utility. And I thought that it was a simple bug: the
aclocal regexp was not taking into account the possibility of assigning
to a variable name starting with "AM_".
-Steve
On Fri, Jan 05, 2001 at 10:00:16PM -0500, steve wrote:
>
> Hi,
>
> I just wrote a configure.in that assigns to AM_CFLAGS, and aclocal
> barfed on it:
>
> aclocal: configure.in: 12: macro `AM_CFLAGS' not found in library
>
> Assuming this is deemed a reasonable thing to allow, the attached patch
> (against current CVS automake) will fix it.
>
> -Steve
>
>
>
> 2001-01-05 Steve Robbins <address@hidden>
>
> * aclocal.in (scan_configure): Don't mistake variable
> assignment for a macro.
>
>
>
>
> Index: aclocal.in
> ===================================================================
> RCS file: /cvs/automake/automake/aclocal.in,v
> retrieving revision 1.50
> diff -u -b -B -r1.50 aclocal.in
> --- aclocal.in 2000/11/16 11:07:37 1.50
> +++ aclocal.in 2001/01/06 02:54:06
> @@ -240,7 +240,7 @@
>
> # Search for things we know about. The "search" sub is
> # constructed dynamically by scan_m4_files.
> - if (! &search && /(^|\s+)(AM_[A-Z_]+)/)
> + if (! &search && /(^|\s+)(AM_[A-Z_]+)(\=?)/ && !$3)
> {
> # Macro not found, but AM_ prefix found.
> warn "aclocal: configure.in: $.: macro \`$2' not found in
> library\n";
- Re: AM_CFLAGS,
Steve Robbins <=