[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] doc: clarify integer requirements in some functions
From: |
Mike Frysinger |
Subject: |
Re: [PATCH] doc: clarify integer requirements in some functions |
Date: |
Sat, 12 Feb 2022 04:03:47 -0500 |
On 12 Feb 2022 00:35, Paul Eggert wrote:
> On 2/12/22 00:28, Mike Frysinger wrote:
> > These functions do not accept decimal values with fractional parts.
> > Describe them in terms of integers to clarify.
>
> I dunno, those values all must be integers by their nature so saying
> "integer" in the doc doesn't help much; conversely, if the doc omits the
> word "decimal" people might think the numbers could be octal or hex.
perhaps one can argue that for the help description macros if we assume anyone
working on this code is fully versed in terminal output behavior, but i don't
think you can argue that for the min/max functions, nor for the arith ones. i
don't think, based on the description of AS_VAR_ARITH, this is unreasonable:
blah=2
AS_VAR_ARITH([foo], [$blah + 0.1])
-mike
signature.asc
Description: PGP signature