[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] _AC_PROG_CXX_STDCXX_EDITION_TRY: fix typo in variable name
From: |
Eric Blake |
Subject: |
Re: [PATCH] _AC_PROG_CXX_STDCXX_EDITION_TRY: fix typo in variable name |
Date: |
Wed, 30 Jun 2021 14:55:36 -0500 |
User-agent: |
NeoMutt/20210205-553-3af687-dirty |
On Fri, May 14, 2021 at 09:06:20AM +0300, Emanuele Giaquinta wrote:
> The typo causes "ac_prog_cxx_stdcxx" to be always set to "cxx11",
> regardless of whether the C++ compiler supports C++11.
> ---
> lib/autoconf/c.m4 | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/autoconf/c.m4 b/lib/autoconf/c.m4
> index 9f881f0b..47434c89 100644
> --- a/lib/autoconf/c.m4
> +++ b/lib/autoconf/c.m4
> @@ -2749,8 +2749,8 @@ AC_DEFUN([_AC_PROG_CXX_STDCXX_EDITION_TRY],
> [AC_REQUIRE([_AC_CXX_CXX$1_TEST_PROGRAM])]dnl
> [AS_IF([test x$ac_prog_cxx_stdcxx = xno],
> [AC_MSG_CHECKING([for $CXX option to enable C++$1 features])
> -AC_CACHE_VAL(ac_cv_prog_cxx_$1,
> -[ac_cv_prog_cxx_$1=no
> +AC_CACHE_VAL(ac_cv_prog_cxx_cxx$1,
> +[ac_cv_prog_cxx_cxx$1=no
I had to read more context to see that this name matches the comments
above and the resulting _AC_COMPILE_IFELSE below, but agree that it is
correct. Thanks; I've pushed it in your name.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH] _AC_PROG_CXX_STDCXX_EDITION_TRY: fix typo in variable name,
Eric Blake <=