[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Use just-built utilities for help2man rule
|
From: |
Zack Weinberg |
|
Subject: |
Re: [PATCH] Use just-built utilities for help2man rule |
|
Date: |
Wed, 15 Jul 2020 09:53:14 -0400 |
On Wed, Jul 15, 2020 at 7:57 AM Andreas Schwab <schwab@suse.de> wrote:
> -
> PATH="./tests$(PATH_SEPARATOR)$(top_srcdir)/build-aux$(PATH_SEPARATOR)$$PATH";
> \
> +
> PATH="bin$(PATH_SEPARATOR)./tests$(PATH_SEPARATOR)$(top_srcdir)/build-aux$(PATH_SEPARATOR)$$PATH";
> \
This bypasses the wrappers installed in ./tests and therefore causes
each just-built executable to be run *without* the options pointing it
at the matching, not-yet-installed, .m4 and .m4f files. This may be
harmless in this case since we're (I presume) only running the
executables in --help mode, but it's not correct in general and I
don't want to give future hackers reading the Makefiles the wrong
impression.
Under normal circumstances, there should always be a wrapper in
./tests for each executable in ./bin. Exactly what did you do that
made you think this patch was necessary? Please be excruciatingly
detailed.
zw