[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Support for Flang and ARM HPC compiler
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH] Support for Flang and ARM HPC compiler |
|
Date: |
Wed, 30 Aug 2017 08:19:42 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 08/30/2017 06:55 AM, address@hidden wrote:
> From: root <address@hidden>
Looks like you failed to properly configure your git.
> -m4_define([_AC_F95_FC], [gfortran g95 xlf95 f95 fort ifort ifc efc pgfortran
> pgf95 lf95 ftn nagfor])
> +# flang: LLVM Fortran compiler
> +# armflang: ARM HPC Fortran compiler
> +m4_define([_AC_F95_FC], [gfortran g95 xlf95 f95 fort ifort ifc efc armflang
> flang pgfortran pgf95 lf95 ftn nagfor])
It would be nice to wrap this to avoid a long line in the source, but
that's minor.
I'm not a fortran expert, so I can't test this, but in principle the
patch looks reasonable; and it is small enough to not need copyright
assignment. However, I wonder if it does need mention in NEWS, so I'll
wait a bit longer before applying to see if anyone else chimes in on review.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature