Re: [PATCH v3 0/4] limit number of cat and sed forks

[Eric Blake]

On 11/05/2016 04:16 AM, Paolo Bonzini wrote:
> 
> 
> On 04/11/2016 03:37, Eric Blake wrote:
>> Work in progress, because I still have to review patches 2 and 3
>> from Paolo's v2. (Patch 3 can probably be used as-is; patch 2
>> will probably necessitate the same changes to CHECK_DECLS_ONCE for
>> honoring AC_LANG and reworking the shell list variable to hold
>> tuples as I do here for CHECK_FUNCS_ONCE).
>>
>> The end result is the same number of processes shaved as in Paolo's
>> v2 patch 1/3, but now the code is no longer subject to subtle
>> semantic differences (the ONCE functions are still checked in the
>> same sequence in relation to the rest of configure as before), and
>> the configure script does not grow quite as large (on coreutils,
>> Paolo's cost about 17k, my approach cost about 2k).
>>
>> Eric Blake (3):
>>   AC_CHECK_FUNCS_ONCE: honor current AC_LANG
>>   AC_CHECK_FUNCS_ONCE: hoist CPP name computation to m4 time
>>   AC_CHECK_FUNCS_ONCE: hoist cache name computation to m4 time
>>
>> Paolo Bonzini (1):
>>   autoconf: prefer an unrolled loop for trivial AC_CHECK_FUNCS
>>
>>  NEWS                      |  4 ++++
>>  lib/autoconf/functions.m4 | 60 
>> +++++++++++++++++++++++++++++++++--------------
>>  2 files changed, 47 insertions(+), 17 deletions(-)
>>
> 
> 
> Looks good, thanks!

Apologies for sitting on this for over a month, but I finally had time
to finish the series, and basically duplicated the AC_CHECK_FUNCS*
patches into corresponding AC_CHECK_HEADERS* versions, and pushed the
result.

Thanks again for your initial investigation on how to reduce some of the
fork expense of configure files.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature