[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] m4_set_foreach: pop macro definition
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH] m4_set_foreach: pop macro definition |
|
Date: |
Tue, 21 Apr 2015 06:02:03 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 04/20/2015 07:16 PM, Nick Bowler wrote:
> Turns out the implementation already had a pushdef, and it looks like
> the popdef was simply forgotten. Add it now.
Thanks for catching that.
> m4_define([m4_set_foreach],
> -[m4_pushdef([$2])m4_set_map_sep([$1], [m4_define([$2],], [)$3])])
> +[m4_pushdef([$2])m4_set_map_sep([$1], [m4_define([$2],], [)$3])dnl
> +m4_popdef([$2])])
I'm going to push a followup that avoids a 'dnl' in the middle of the
macro. With 'dnl' right there, ALL expansions have to further go through
one more macro expansion.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature