Re: [PATCH 2/4] AC_PROG_LEX: Rephrase LEX is set test

[Eric Blake]

On 04/09/2015 06:43 AM, Bernhard Reutner-Fischer wrote:
> 2015-04-08  Bernhard Reutner-Fischer  <address@hidden>
> 
>       * lib/autoconf/programs.m4 (AC_PROG_LEX): Rephrase LEX is set
>       test.
> 
> Signed-off-by: Bernhard Reutner-Fischer <address@hidden>
> ---
>  lib/autoconf/programs.m4 |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/autoconf/programs.m4 b/lib/autoconf/programs.m4
> index 931177b..abf554c 100644
> --- a/lib/autoconf/programs.m4
> +++ b/lib/autoconf/programs.m4
> @@ -709,7 +709,7 @@ AN_PROGRAM([lex],  [AC_PROG_LEX])
>  AN_PROGRAM([flex], [AC_PROG_LEX])
>  AC_DEFUN_ONCE([AC_PROG_LEX],
>  [AC_CHECK_PROGS(LEX, flex lex, :)
> -if test "x$LEX" != "x:"; then
> +if [[ ${LEX:+y} ]]; then

NACK. This is checking if $LEX is specifically something other than ':',
not whether it is empty.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature