autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix spurious testsuite failure when /bin/sh is dash


From: Stefano Lattarini
Subject: Re: [PATCH] Fix spurious testsuite failure when /bin/sh is dash
Date: Fri, 19 Dec 2014 12:28:01 +0100

On 12/17/2014 02:18 PM, Stefano Lattarini wrote:
The testsuite used slightly different logic in the code employed to
decide whether a test should be skipped due to a limitation of the
selected shell, and in the code running the test itself.

* tests/autotest.at (Syntax error): Adjust.
(parallel syntax error): Likewise.

Signed-off-by: Stefano Lattarini <address@hidden>
---
  tests/autotest.at | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/autotest.at b/tests/autotest.at
index a985f86..8182c83 100644
--- a/tests/autotest.at
+++ b/tests/autotest.at
@@ -397,7 +397,7 @@ AT_CHECK_AT_TEST([Syntax error],
     AT_CHECK([${CONFIG_SHELL-$SHELL} -c 'case `. ./syntax; echo $?` in
                  0|"") exit 77;;
                esac'], [0], [ignore], [ignore])
-   AT_CHECK([$CONFIG_SHELL ./micro-suite], [1], [ignore], [stderr])
+   AT_CHECK([${CONFIG_SHELL-$SHELL} ./micro-suite], [1], [ignore], [stderr])
     AT_CHECK([grep "unable to parse test group: 2" stderr], [0], [ignore])],
    [1 3])

@@ -1507,7 +1507,7 @@ AT_CHECK_AT_TEST([parallel syntax error],
     AT_CHECK([${CONFIG_SHELL-$SHELL} -c 'case `. ./syntax; echo $?` in
                  0|"") exit 77;;
                esac'], [0], [ignore], [ignore])
-   AT_CHECK([$CONFIG_SHELL ./micro-suite -j], [1], [ignore], [stderr])
+   AT_CHECK([${CONFIG_SHELL-$SHELL} ./micro-suite -j], [1], [ignore], [stderr])
     AT_CHECK([grep "unable to parse test group: 2" stderr], [0], [ignore])],
    [-j2 1 3])


Will push in a couple of days if nobody objects.

Regards,
  Stefano



reply via email to

[Prev in Thread] Current Thread [Next in Thread]