autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] maint: avoid new syntax-check failure


From: Jim Meyering
Subject: [PATCH] maint: avoid new syntax-check failure
Date: Sun, 22 Jul 2012 22:51:58 +0200

I suggest to update maint.mk soon to the latest from gnulib,
mainly for its new check for the CVE-2012-3386 (make distcheck) bug.
Once you do that, you see a new "make syntax-check" failure,
triggered by this example from autoconf.texi:

    @example
    #if !HAVE_DECL_SYMBOL
    extern char *symbol;
    #endif
    @end example

    @noindent
    If the test may have not been performed, however, because it is safer
    @emph{not} to declare a symbol than to use a declaration that conflicts
    with the system's one, you should use:

    @example
>>  #if defined HAVE_DECL_MALLOC && !HAVE_DECL_MALLOC
    void *malloc (size_t *s);
    #endif
    @end example

Here's a fix for that that should be pushed first.
This probably counts as trivial, but I'll wait for an ACK.

>From 32d938eaa7e1cb756997a665cb1669ef6dca3110 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sun, 22 Jul 2012 12:26:26 +0200
Subject: [PATCH] maint: avoid new syntax-check failure

* cfg.mk (exclude_file_name_regexp--sc_prohibit_defined_have_decl_tests):
Exempt autoconf.texi's test of "#if defined HAVE_DECL_MALLOC".
---
 cfg.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/cfg.mk b/cfg.mk
index a992abb..4300f04 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -137,3 +137,5 @@ exclude_file_name_regexp--sc_useless_cpp_parens = \
 exclude_file_name_regexp--sc_trailing_blank = ^build-aux/texinfo\.tex$$
 exclude_file_name_regexp--sc_two_space_separator_in_usage = \
   ^build-aux/gnupload$$
+exclude_file_name_regexp--sc_prohibit_defined_have_decl_tests = \
+  ^doc/autoconf\.texi$$
--
1.7.11.2.249.g31c7954



reply via email to

[Prev in Thread] Current Thread [Next in Thread]