Re: [PATCH] tests: use configure.ac, not configure.in, with aclocal/automake involved

[Stefano Lattarini]

On 07/21/2012 05:51 PM, Jim Meyering wrote:
> Stefano Lattarini wrote:
> 
>> Do so because future automake and aclocal versions (starting from 1.13)
>> won't support 'configure.in' anymore as the name of the Autoconf input
>> file.  Without this patch, the Autoconf testsuite experience some
>> spurious failures when run with the development version of aclocal and
>> automake installed somewhere in $PATH.
>>
>> * tests/torture.at: Rename 'configure.in' to 'configure.ac' throughout.
>>
>> Signed-off-by: Stefano Lattarini <address@hidden>
>> ---
>>  tests/torture.at | 28 ++++++++++++++--------------
>>  1 file changed, 14 insertions(+), 14 deletions(-)
>>
>> diff --git a/tests/torture.at b/tests/torture.at
>> index 9923305..db10e9c 100644
>> --- a/tests/torture.at
>> +++ b/tests/torture.at
>> @@ -1444,10 +1444,10 @@ export CONFIG_SITE
>>  # The contents of `inner/', and `inner/innermost/'.
>>  AS_MKDIR_P([inner/innermost])
>>
>> -# We have to use configure.in, not configure.ac, if we still want to
>> +# We have to use configure.ac, not configure.ac, if we still want to
> 
> That comment now makes no sense.
>
Oops, sorry.  The risk of automated changes ...

> I'd remove the comment altogether,
>
Done.  Here is the updated commit message:

    tests: use configure.ac, not configure.in, with aclocal/automake involved

    Do so because future automake and aclocal versions (starting from 1.13)
    won't support 'configure.in' anymore as the name of the Autoconf input
    file.  Without this patch, the Autoconf testsuite experience some
    spurious failures when run with the development version of aclocal and
    automake installed somewhere in $PATH.

    * tests/torture.at: Rename 'configure.in' to 'configure.ac' throughout.
    Remove an obsolete comment about backwards-compatibility.

    Helped-by: Jim Meyering <address@hidden>

> since with this change we're obviously breaking with automake-1.4 ;-)
>
> Otherwise, this change looks fine.
>

Thanks,
  Stefano