autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Autoconf-2.68b possible patch for FreeBSD, MacOS X


From: Paul Eggert
Subject: Re: Autoconf-2.68b possible patch for FreeBSD, MacOS X
Date: Wed, 07 Mar 2012 14:32:42 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120209 Thunderbird/10.0.1

On 03/07/2012 01:42 PM, P. Martin wrote:
> The test dirs from adding your patch are now up on my repo:
> https://github.com/2bits/actest

Thanks, that helps.  The issue is clearly due to the limited
'grep -E' implementation on that platform: it sometimes
(but not always!) complains 'Regular expression too big'
for a 938-byte regular expression in the test.

I hope the following further patch,
which is clearly needed anyway and which I just now pushed,
fixes the remaining problems.

>From 0f133bbea81a9e3cea1278577f498d617b89c5d8 Mon Sep 17 00:00:00 2001
From: Paul Eggert <address@hidden>
Date: Wed, 7 Mar 2012 14:22:54 -0800
Subject: [PATCH] tests: fix port of AT_CHECK_ENV to hosts with flaky grep

* tests/local.at (AT_CHECK_ENV): Don't copy the buggy grep's
diagnostics to stderr, as that causes AT_CHECK to fail.  They can
be found in the stderr-* files if this is needed for debugging.
---
 tests/local.at |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/tests/local.at b/tests/local.at
index 66027e8..40b7318 100644
--- a/tests/local.at
+++ b/tests/local.at
@@ -331,10 +331,7 @@ if test -f state-env.before && test -f state-env.after; 
then
       # There may be variables spread on several lines; remove latter lines.
       $GREP '^m4_defn([m4_re_word])=' >clean-$act_file ||
         test $? -eq 1 || grep_failed=:
-    if test -s stderr-$act_file; then
-      cat stderr-$act_file >&2
-      grep_failed=:
-    fi
+    test -s stderr-$act_file && grep_failed=:
   done
   $at_traceon
   $grep_failed || $at_diff clean-state-env.before clean-state-env.after
-- 
1.7.6.5




reply via email to

[Prev in Thread] Current Thread [Next in Thread]