autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/7] maint: placate syntax-check rules: exempt some false pos


From: Eric Blake
Subject: Re: [PATCH 4/7] maint: placate syntax-check rules: exempt some false positives
Date: Mon, 23 Jan 2012 08:14:56 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0

On 01/21/2012 08:28 AM, Jim Meyering wrote:
> Jim Meyering wrote:
>> Eric Blake wrote:
> ...
>>> Incomplete.  I'd rather see this patch nuke all of the .x-sc files and
>>> convert them into exclude_file_name_regexp entries.
>>
>> That will be an improvement, but it does not belong in this series.
>> This series is addressing preexisting (and a few new, with sync)
>> syntax-check failures.  What you're proposing is most welcome (moving the
>> exemptions from numerous separate files into cfg.mk), but it qualifies
>> as a no-semantic-change and deserves to be separate.
> 
> I did as you suggested.
> 
>>From 46322d672635d018949a05775cc120d36c15be6e Mon Sep 17 00:00:00 2001
> From: Jim Meyering <address@hidden>
> Date: Sat, 21 Jan 2012 16:12:45 +0100
> Subject: [PATCH] maint: convert .x-sc_* into exclude_file_name_regexp--sc_*
>  exemptions
> 
> Many of the .x-sc_* exemptions were no long necessary.  Remove those
> files and instead, provide exemptions via variable definitions in
> cfg.mk to address the few remaining exceptions.

Thanks for this followup, and ACK.

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]