[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests: skip broken automake wrapper on MirBSD
From: |
Stefano Lattarini |
Subject: |
Re: [PATCH] tests: skip broken automake wrapper on MirBSD |
Date: |
Mon, 13 Sep 2010 18:20:21 +0200 |
User-agent: |
KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) |
Hi Eric. Just a little nitpicking...
On Monday 13 September 2010, Eric Blake wrote:
> diff --git a/tests/tools.at b/tests/tools.at
> index 167d68a..e4e119b 100644
> --- a/tests/tools.at
> +++ b/tests/tools.at
> @@ -1164,8 +1164,9 @@ AT_SETUP([autom4te preselections])
> # If this test should run on FAT file systems and older w32,
> # then setting $sleep correctly needs to be revisited.
>
> -# We use aclocal and automake.
> -AT_CHECK([automake --version || exit 77], [], [ignore], [ignore])
> +# We use aclocal and automake. Skip broken automake wrappers.
> +AT_CHECK([automake --version || exit 77], [], [stdout], [ignore])
> +AT_CHECK([[grep '[1-9]\.[0-9][0-9]*' stdout || exit 77]], [],
Wouldn't "grep '[1-9]\.[0-9]'" be enough here? Ditto for the other
occurrences in the patch.
Regards,
Stefano