autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] config.status: minimize use of $tmp


From: Paul Eggert
Subject: Re: [PATCH 2/2] config.status: minimize use of $tmp
Date: Mon, 30 Aug 2010 11:29:25 -0700
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.11) Gecko/20100713 Thunderbird/3.0.6

On 08/30/10 09:41, Eric Blake wrote:
> -  { test ! -d "${ac_tmp:=$tmp}" || rm -fr "$ac_tmp"; } && exit $exit_status
> 
> +  : "${ac_tmp:=$tmp}"
> +  { test ! -d "$ac_tmp" || rm -fr "$ac_tmp"; } && exit $exit_status

I agree with Ralf on this point.  That is,
I don't know of any shells where this change is needed, and
in POSIX-conforming shells this change is not needed.  I wouldn't
bother with changes like this unless there is a known and
significant shell with the bug in question.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]