autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Close job control fd before running tests.


From: Ralf Wildenhues
Subject: Re: [PATCH] Close job control fd before running tests.
Date: Wed, 21 Jul 2010 06:24:04 +0200
User-agent: Mutt/1.5.20 (2010-04-22)

Hi Eric,

I submitted another patch for this issue, and I don't think your patch
is quite right:

* Eric Blake wrote on Wed, Jul 21, 2010 at 06:14:45AM CEST:
> --- a/doc/autoconf.texi
> +++ b/doc/autoconf.texi
> @@ -15006,7 +15006,7 @@ File Descriptors
>  Within the process which runs the @samp{descrips} script, file
>  descriptor 5 is closed.
> 
> -Don't rely on redirection to a closed file descriptor to cause an
> +Don't rely on duplicating a closed file descriptor to cause an
>  error.  With Solaris @command{/bin/sh}, when the redirection fails, the
>  output goes to the original file descriptor.
> 
> @@ -15019,6 +15019,12 @@ File Descriptors
>  0
>  @end example
> 
> +Fortunately, an attempt to close an already closed file descriptor will
> +portably succeed.

This is not true.  ksh93, for example, will happily fail to close a
closed fd.  You need to try in non-interactive mode.

Cheers,
Ralf



reply via email to

[Prev in Thread] Current Thread [Next in Thread]