[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Another empty argument through expr workaround.
From: |
Eric Blake |
Subject: |
Re: [PATCH] Another empty argument through expr workaround. |
Date: |
Tue, 20 Jul 2010 08:28:48 -0600 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Mnenhy/0.8.3 Thunderbird/3.0.5 |
On 07/20/2010 08:17 AM, Ralf Wildenhues wrote:
> Hi Eric,
>
> * Eric Blake wrote on Tue, Jul 20, 2010 at 04:11:04PM CEST:
>> --- a/lib/autoconf/status.m4
>> +++ b/lib/autoconf/status.m4
>> @@ -1464,6 +1464,11 @@ ac_need_defaults=:
>> while test $[#] != 0
>> do
>> case $[1] in
>> + --*=)
>
> This isn't right. It also matches --foo=ends-in-=
Good catch. I guess I have to follow your lead, then:
--*=?*) # use expr
--*=) # empty arg
rather than my attempt:
--*=) # empty arg
--*=*) # use expr
And while fixing that, I also noticed a bug. Try:
./config.status --file
(or for more fun, 'touch .in; ./config.status --file=').
Patch respin coming up...
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature