Re: [PATCH] Make AS_TR_SH and AS_TR_CPP similar.

[Stefano Lattarini]

Hello Eric.

At Friday 02 July 2010, Eric Blake wrote:
> * lib/m4sugar/m4sh.m4 (_AS_TR_CPP_LITERAL): Avoid underquoting.
> (_AS_TR_CPP_INDIR): Handle all polymorphic variables.
> * tests/m4sh.at (AS@&address@hidden and AS@&address@hidden): New test.
> * NEWS: Document the fix.
> Reported by Bruno Haible.
> 
> [CUT]
>
> diff --git a/tests/m4sh.at b/tests/m4sh.at
> index f5ea7e2..bd915c0 100644
> --- a/tests/m4sh.at
> +++ b/tests/m4sh.at
> @@ -1169,6 +1169,78 @@ ok 16
>  AT_CLEANUP
> 
> 
> +## --------------------- ##
> +## AS_TR_SH, AS_TR_CPP.  ##
> +## --------------------- ##
> +
> +AT_SETUP([AS@&address@hidden and AS@&address@hidden)
> +
> +AT_DATA_M4SH([script.as], [[dnl
> +AS_INIT
> +m4_define([abc], [hI])m4_define([ABC], [Hi])
> +m4_define([hi], [oops])m4_define([HI], [OOPS])
> +echo AS_TR_SH(abc) AS_TR_SH(aBc) AS_TR_SH(ABC)
> +echo AS_TR_SH([abc]) AS_TR_SH([aBc]) AS_TR_SH([ABC])
> +echo AS_TR_SH([[abc]]) AS_TR_SH([[aBc]]) AS_TR_SH([[ABC]])
> +echo AS_TR_CPP(abc) AS_TR_CPP(aBc) AS_TR_CPP(ABC)
> +echo AS_TR_CPP([abc]) AS_TR_CPP([aBc]) AS_TR_CPP([ABC])
> +echo AS_TR_CPP([[abc]]) AS_TR_CPP([[aBc]]) AS_TR_CPP([[ABC]])
> +echo ===
> +[var=abc vAr=aBc VAR=ABC]
> +echo AS_TR_SH($var) AS_TR_SH($vAr) AS_TR_SH($VAR)
> +echo AS_TR_SH([$var]) AS_TR_SH([$vAr]) AS_TR_SH([$VAR])
> +echo AS_TR_SH([[$var]]) AS_TR_SH([[$vAr]]) AS_TR_SH([[$VAR]])
> +echo AS_TR_CPP($var) AS_TR_CPP($vAr) AS_TR_CPP($VAR)
> +echo AS_TR_CPP([$var]) AS_TR_CPP([$vAr]) AS_TR_CPP([$VAR])
> +echo AS_TR_CPP([[$var]]) AS_TR_CPP([[$vAr]]) AS_TR_CPP([[$VAR]])
> +echo ===
> +var=abc vAr=aBc VAR=ABC
I've just thrown a quick glance at your patch, so this might be a stupid
question... but what are these assignements above required for?
They seem not to be needed here...
> +echo AS_TR_SH(`echo abc`) AS_TR_SH(`echo aBc`) AS_TR_SH(`echo ABC`)
> +echo AS_TR_SH([`echo abc`]) AS_TR_SH([`echo aBc`]) AS_TR_SH([`echo ABC`])
> +echo AS_TR_SH([[`echo abc`]]) AS_TR_SH([[`echo aBc`]]) AS_TR_SH([[`echo 
> ABC`]])
> +echo AS_TR_CPP(`echo abc`) AS_TR_CPP(`echo aBc`) AS_TR_CPP(`echo ABC`)
> +echo AS_TR_CPP([`echo abc`]) AS_TR_CPP([`echo aBc`]) AS_TR_CPP([`echo ABC`])
> +echo AS_TR_CPP([[`echo abc`]]) AS_TR_CPP([[`echo aBc`]]) AS_TR_CPP([[`echo 
> ABC`]])
> [CUT]

Regards,
   Stefano